Call SetDllDirectory("") after sqlite3 init on cygwin #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
reviewed
Jun 20, 2017
src/libstore/local-store.cc
Outdated
| if (kernel32) | ||
| { | ||
| BOOL WINAPI (*setDllDirectory)(LPCWSTR) = | ||
| (BOOL WINAPI (*)(LPCWSTR))GetProcAddress(kernel32, "SetDllDirectoryW"); |
There was a problem hiding this comment.
Why does setDllDirectory need to be looked up dynamically? Isn't it declared in windows.h?
There was a problem hiding this comment.
I borrowed that from cygwin. I presume it's for ancient versions of windows. The API was added in XP/2003, so it was extreme overkill. I've switched it over.
This will change build behaviour. Is there some sort of global key I should increment to force rebuilds on cygwin?
Cygwin sqlite3 is patched to call SetDllDirectory("/usr/bin") on init, which
affects the current process and is inherited by child processes. It causes
DLLs to be loaded from /usr/bin/ before $PATH, which breaks all sorts of
things. A typical failures would be header/lib version mismatches (e.g.
openssl when running checkPhase on openssh). We'll just set it back to the
default value.
Note that this is a problem with the cygwin version of sqlite3 (currently
3.18.0). nixpkgs doesn't have the problematic patch.
|
@edolstra I was thinking of some sort of seed or version value that would be included in every derivation hash. I had a quick look and didn't see anything obvious. It's not a big deal because in my experience so far this has caused the affected packages to fail on build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cygwin sqlite3 is patched to call SetDllDirectory("/usr/bin") on init, which
affects the current process and is inherited by child processes. It causes
DLLs to be loaded from /usr/bin/ before $PATH, which breaks all sorts of
things. A typical failures would be header/lib version mismatches (e.g.
openssl when running checkPhase on openssh). We'll just set it back to the
default value.
Note that this is a problem with the cygwin version of sqlite3 (currently
3.18.0). nixpkgs doesn't have the problematic patch.
This is obviously a hack, and I will look into addressing it in the cygwin package.