-
-
Notifications
You must be signed in to change notification settings - Fork 925
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove BigInteger from values which probably will never need them lik…
…e year. This improves my bench a bit more (BEFORE): ```text jruby ../snippets/date_bench.rb Warming up -------------------------------------- _strptime 26.267k i/100ms Calculating ------------------------------------- _strptime 319.069k (± 5.8%) i/s - 3.178M in 9.998810s ``` AFTER: ```text jruby ../snippets/date_bench.rb Warming up -------------------------------------- _strptime 29.320k i/100ms Calculating ------------------------------------- _strptime 353.076k (± 2.9%) i/s - 3.548M in 10.057641s ``` I also examined MRIs implementation and they basically do all dyncalls for all the math which this rewrite in Java does not do. I think this is ok but it underlies how much more overhead may be lurking here (since we are doing direct Java math). I did not change seconds and smaller units of time since they may exceed long boundary. In that case a followup optimization would be to check digits of text and flip to BigInteger only in those cases otherwise assume long or even int when it fits.
- 9.4.12.0
- 9.4.11.0
- 9.4.10.0
- 9.4.9.0
- 9.4.8.0
- 9.4.7.0
- 9.4.6.0
- 9.4.5.0
- 9.4.4.0
- 9.4.3.0
- 9.4.2.0
- 9.4.1.0
- 9.4.0.0
- 9.3.15.0
- 9.3.14.0
- 9.3.13.0
- 9.3.12.0
- 9.3.11.0
- 9.3.10.0
- 9.3.9.0
- 9.3.8.0
- 9.3.7.0
- 9.3.6.0
- 9.3.5.0
- 9.3.4.0
- 9.3.3.0
- 9.3.2.0
- 9.3.1.0
- 9.3.0.0
- 9.2.21.0
- 9.2.20.1
- 9.2.20.0
- 9.2.19.0
- 9.2.18.0
- 9.2.17.0
- 9.2.16.0
- 9.2.15.0
- 9.2.14.0
- 9.2.13.0
- 9.2.12.0
- 9.2.11.1
- 9.2.11.0
- 9.2.10.0
- 9.2.9.0
- 9.2.8.0
- 9.2.7.0
- 9.2.6.0
- 9.2.5.0
- 9.2.4.1
- 9.2.4.0
- 9.2.3.0
- 9.2.2.0
- 9.2.1.0
- 9.2.0.0
Showing
1 changed file
with
59 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters