Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2b31e72a9cdb
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f827d499a1ff
Choose a head ref
  • 2 commits
  • 12 files changed
  • 2 contributors

Commits on Jun 21, 2017

  1. doc: Fix some typos

    (cherry picked from commit e35f3c0)
    jtojnar authored and joachifm committed Jun 21, 2017

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    joachifm Joachim F.
    Copy the full SHA
    eb2ce87 View commit details
  2. kdevelop: 5.0.4 -> 5.1.1

    Including also a patch for bug https://bugs.kde.org/show_bug.cgi?id=379433
    which is a quite annoying regression from 5.0.4. The patch is the same as
    the change committed upstream.
    
    (cherry picked from commit 8f4619b)
    ambrop72 authored and joachifm committed Jun 21, 2017

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    joachifm Joachim F.
    Copy the full SHA
    f827d49 View commit details
2 changes: 1 addition & 1 deletion doc/configuration.xml
Original file line number Diff line number Diff line change
@@ -227,7 +227,7 @@ packages via <literal>packageOverrides</literal></title>

<para>You can define a function called
<varname>packageOverrides</varname> in your local
<filename>~/.config/nixpkgs/config.nix</filename> to overide nix packages. It
<filename>~/.config/nixpkgs/config.nix</filename> to override nix packages. It
must be a function that takes pkgs as an argument and return modified
set of packages.

2 changes: 1 addition & 1 deletion doc/functions.xml
Original file line number Diff line number Diff line change
@@ -70,7 +70,7 @@

<para>
In the above example, the <varname>separateDebugInfo</varname> attribute is
overriden to be true, thus building debug info for
overridden to be true, thus building debug info for
<varname>helloWithDebug</varname>, while all other attributes will be
retained from the original <varname>hello</varname> package.
</para>
2 changes: 1 addition & 1 deletion doc/overlays.xml
Original file line number Diff line number Diff line change
@@ -78,7 +78,7 @@ self: super:
<para>The first argument, usually named <varname>self</varname>, corresponds to the final package
set. You should use this set for the dependencies of all packages specified in your
overlay. For example, all the dependencies of <varname>rr</varname> in the example above come
from <varname>self</varname>, as well as the overriden dependencies used in the
from <varname>self</varname>, as well as the overridden dependencies used in the
<varname>boost</varname> override.</para>

<para>The second argument, usually named <varname>super</varname>,
2 changes: 1 addition & 1 deletion doc/reviewing-contributions.xml
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@
<para>The high change rate of nixpkgs make any pull request that is open for
long enough subject to conflicts that will require extra work from the
submitter or the merger. Reviewing pull requests in a timely manner and being
responsive to the comments is the key to avoid these. Github provides sort
responsive to the comments is the key to avoid these. GitHub provides sort
filters that can be used to see the <link
xlink:href="https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc">most
recently</link> and the <link
12 changes: 6 additions & 6 deletions doc/stdenv.xml
Original file line number Diff line number Diff line change
@@ -1156,15 +1156,15 @@ makeWrapper $out/bin/foo $wrapperfile --prefix PATH : ${lib.makeBinPath [ hello
<term><option>--replace</option>
<replaceable>s1</replaceable>
<replaceable>s2</replaceable></term>
<listitem><para>Replace every occurence of the string
<listitem><para>Replace every occurrence of the string
<replaceable>s1</replaceable> by
<replaceable>s2</replaceable>.</para></listitem>
</varlistentry>

<varlistentry>
<term><option>--subst-var</option>
<replaceable>varName</replaceable></term>
<listitem><para>Replace every occurence of
<listitem><para>Replace every occurrence of
<literal>@<replaceable>varName</replaceable>@</literal> by
the contents of the environment variable
<replaceable>varName</replaceable>. This is useful for
@@ -1177,7 +1177,7 @@ makeWrapper $out/bin/foo $wrapperfile --prefix PATH : ${lib.makeBinPath [ hello
<term><option>--subst-var-by</option>
<replaceable>varName</replaceable>
<replaceable>s</replaceable></term>
<listitem><para>Replace every occurence of
<listitem><para>Replace every occurrence of
<literal>@<replaceable>varName</replaceable>@</literal> by
the string <replaceable>s</replaceable>.</para></listitem>
</varlistentry>
@@ -1225,7 +1225,7 @@ substitute ./foo.in ./foo.out \
<term><function>substituteAll</function>
<replaceable>infile</replaceable>
<replaceable>outfile</replaceable></term>
<listitem><para>Replaces every occurence of
<listitem><para>Replaces every occurrence of
<literal>@<replaceable>varName</replaceable>@</literal>, where
<replaceable>varName</replaceable> is any environment variable, in
<replaceable>infile</replaceable>, writing the result to
@@ -1528,7 +1528,7 @@ bin/blib.a(bios_console.o): In function `bios_handle_cup':
depends on such a format string, it will need to be worked around.
</para>

<para>Addtionally, some warnings are enabled which might trigger build
<para>Additionally, some warnings are enabled which might trigger build
failures if compiler warnings are treated as errors in the package build.
In this case, set <option>NIX_CFLAGS_COMPILE</option> to
<option>-Wno-error=warning-type</option>.</para>
@@ -1558,7 +1558,7 @@ fcntl2.h:50:4: error: call to '__open_missing_mode' declared with attribute erro
<term><varname>pic</varname></term>
<listitem>
<para>Adds the <option>-fPIC</option> compiler options. This options adds
support for position independant code in shared libraries and thus making
support for position independent code in shared libraries and thus making
ASLR possible.</para>
<para>Most notably, the Linux kernel, kernel modules and other code
not running in an operating system environment like boot loaders won't
2 changes: 1 addition & 1 deletion nixos/doc/manual/administration/imperative-containers.xml
Original file line number Diff line number Diff line change
@@ -55,7 +55,7 @@ Thus, if something went wrong, you can get status info using

</para>

<para>If the container has started succesfully, you can log in as
<para>If the container has started successfully, you can log in as
root using the <command>root-login</command> operation:

<screen>
2 changes: 1 addition & 1 deletion nixos/doc/manual/development/option-declarations.xml
Original file line number Diff line number Diff line change
@@ -95,7 +95,7 @@ options = {
</itemizedlist>
</para>

<para>Both approachs have problems.</para>
<para>Both approaches have problems.</para>

<para>Making backends independent can quickly become hard to manage. For
display managers, there can be only one enabled at a time, but the type
2 changes: 1 addition & 1 deletion nixos/doc/manual/development/option-types.xml
Original file line number Diff line number Diff line change
@@ -386,7 +386,7 @@ code before creating a new type.</para>
<listitem><para>For composed types that can take a submodule as type
parameter, this function can be used to substitute the parameter of a
submodule type. It takes a module as parameter and return the type with
the submodule options substituted. It is usally defined as a type
the submodule options substituted. It is usually defined as a type
function call with a recursive call to
<literal>substSubModules</literal>, e.g for a type
<literal>composedType</literal> that take an <literal>elemtype</literal>
2 changes: 1 addition & 1 deletion nixos/doc/manual/release-notes/rl-1509.xml
Original file line number Diff line number Diff line change
@@ -342,7 +342,7 @@ nix-env -f &quot;&lt;nixpkgs&gt;&quot; -iA haskellPackages.pandoc

<listitem>
<para>
Python 2.6 has been marked as broken (as it no longer recieves
Python 2.6 has been marked as broken (as it no longer receives
security updates from upstream).
</para>
</listitem>
2 changes: 1 addition & 1 deletion nixos/doc/manual/release-notes/rl-1603.xml
Original file line number Diff line number Diff line change
@@ -362,7 +362,7 @@ services.syncthing = {
<listitem>
<para>
<literal>networking.firewall.allowPing</literal> is now enabled by
default. Users are encourarged to configure an approiate rate limit for
default. Users are encouraged to configure an appropriate rate limit for
their machines using the Kernel interface at
<filename>/proc/sys/net/ipv4/icmp_ratelimit</filename> and
<filename>/proc/sys/net/ipv6/icmp/ratelimit</filename> or using the
7 changes: 3 additions & 4 deletions pkgs/applications/editors/kdevelop5/kdevelop.nix
Original file line number Diff line number Diff line change
@@ -9,16 +9,15 @@

let
pname = "kdevelop";
version = "5.0.4";
dirVersion = "5.0.4";
version = "5.1.1";

in
stdenv.mkDerivation rec {
name = "${pname}-${version}";

src = fetchurl {
url = "mirror://kde/stable/${pname}/${dirVersion}/src/${name}.tar.xz";
sha256 = "191142b2bdb14837c82721fdfeb15e852329f2c4c0d48fd479c57514c3235d55";
url = "mirror://kde/stable/${pname}/${version}/src/${name}.tar.xz";
sha256 = "0a01a4ffb2f01802cf4945521a3149a8f82c21fa8a97935991f1854b7db5d754";
};

nativeBuildInputs = [
17 changes: 12 additions & 5 deletions pkgs/applications/editors/kdevelop5/kdevplatform.nix
Original file line number Diff line number Diff line change
@@ -1,23 +1,30 @@
{ stdenv, fetchurl, cmake, gettext, pkgconfig, extra-cmake-modules, makeQtWrapper
{ stdenv, fetchurl, fetchpatch, cmake, gettext, pkgconfig, extra-cmake-modules, makeQtWrapper
, boost, subversion, apr, aprutil
, qtscript, qtwebkit, grantlee, karchive, kconfig, kcoreaddons, kguiaddons, kiconthemes, ki18n
, kitemmodels, kitemviews, kio, kparts, sonnet, kcmutils, knewstuff, knotifications
, knotifyconfig, ktexteditor, threadweaver, kdeclarative, libkomparediff2 }:

let
pname = "kdevplatform";
version = "5.0.4";
dirVersion = "5.0.4";
version = "5.1.1";

in
stdenv.mkDerivation rec {
name = "${pname}-${version}";

src = fetchurl {
url = "mirror://kde/stable/kdevelop/${dirVersion}/src/${name}.tar.xz";
sha256 = "01abfcd71383048d017fe989ccce0e7590010a3975bbe6e161f55ababe2ad471";
url = "mirror://kde/stable/kdevelop/${version}/src/${name}.tar.xz";
sha256 = "3159440512b1373c1a4b35f401ba1f81217de9578372b45137af141eeda6e726";
};

patches = [
(fetchpatch {
name = "kdevplatform-project-selection.patch";
url = "https://cgit.kde.org/kdevplatform.git/patch/?id=da4c0fdfcf21dc2a8f48a2b1402213a32effd47a";
sha256 = "16ws8l6dciy2civjnsaj03ml2bzvg4a9g7gd4iyx4hprw65zrcxm";
})
];

nativeBuildInputs = [ cmake gettext pkgconfig extra-cmake-modules makeQtWrapper ];

propagatedBuildInputs = [ ];