qt5ct module: expose qtstyleplugins #26761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I use KDE, I would like to have the whole thing working and not have to care about details and features like this. Can you make it such that by default this feature is also activated in that case? Regardless, of this feature request, this can be merged. |
|
@0xABAB Sorry, can't get it. qt5ct tool is intended for thoose, who don't use KDE. In KDE you set theming options including Qt/Gtk uniform look via KDE's System Settings. |
|
@gnidorah In that case I have no comments. |
0xABAB
approved these changes
Jul 1, 2017
ghost
closed this
ghost
deleted the
|
Maybe somebody could merge this PR. It is becoming too old. |
peterhoeg
reviewed
Jul 23, 2017
| @@ -30,4 +30,5 @@ in { | |||
|
|
|||
| }; | |||
|
|
|||
| meta.maintainers = [ maintainers.gnidorah ]; | |||
There was a problem hiding this comment.
nitpick: please use = with maintainers; [ gnidorah ];
|
@ttuegel is doing major work on the KDE/qt infrastructure right now - once he's done, I'll merge this. |
|
@peterhoeg Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add qtstyleplugins as runtime dependency, so GTK2 theme can be choosen as Qt 5 theme, like it was possible with Qt 4's qtconfig utility.
https://wiki.archlinux.org/index.php/Uniform_look_for_Qt_and_GTK_applications#QGtkStyle
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)