Skip to content

libunwind: 1.1 -> 1.2.1 #26891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2017
Merged

libunwind: 1.1 -> 1.2.1 #26891

merged 1 commit into from
Jun 27, 2017
+6 −102

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Jun 27, 2017

Motivation for this change

libunwind 1.2.1 includes all patches for libunwind 1.1, except that libunwind-1.1-lzma.patch would have been relevant without autoreconfHook.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Tested compilation of some packages that depend on libunwind: strace, julia.

Sorry, something went wrong.

@Mic92 Mic92 merged commit c30cf6f into NixOS:master Jun 27, 2017
@vbgl
Copy link
Contributor

vbgl commented Jul 3, 2017

This broke julia_05. Updating it to version 0.5.2 does not seem to help. Updating to version 0.6.0 seems non-trivial. Any idea?

@vcunat
Copy link
Member

vcunat commented Jul 3, 2017

In the worst case, one can always bring back an old version privately for julia...

@vcunat
Copy link
Member

vcunat commented Jul 3, 2017

That easy possibility is quite a distinct advantage of nix(pkgs) over standard distros...

@orivej
Copy link
Contributor Author

orivej commented Jul 3, 2017

It seems this is a bug in libunwind which is trivial to patch. Its include/libunwind-common.h contains

#define UNW_VERSION_MAJOR	1
#define UNW_VERSION_MINOR	2.1
#define UNW_VERSION_EXTRA

I'll look into it.

@orivej orivej mentioned this pull request Jul 3, 2017
Closed
orivej added a commit to orivej/nixpkgs that referenced this pull request Jul 3, 2017
@orivej
libunwind: fix version macros
9ccdf60 
Fixes julia_05 build: NixOS#26891
@orivej orivej mentioned this pull request Jul 3, 2017
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@orivej @vbgl @vcunat @Mic92