Skip to content

Commit

Permalink
qtinstaller: fix broken meta
Browse files Browse the repository at this point in the history 
The invalid meta.outputsToInstall has been blocking channel updates.
https://mailman.science.uu.nl/pipermail/nix-dev/2017-June/023991.html
  • Loading branch information
@vcunat
vcunat committed Jun 26, 2017
1 parent 456089b commit ce8178e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkgs/development/libraries/qtinstaller/default.nix
View file
Expand Up @@ -39,7 +39,8 @@ stdenv.mkDerivation rec {
moveToOutput "lib/libinstaller.so.1.0.0" "$out"
'';

meta = (qtbase.meta) // {
meta = {
description = ''Qt installer framework'';
inherit (qtbase.meta) platforms license homepage;
};
}

6 comments on commit ce8178e

@copumpkin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add some sort of check to #25304. I would still prefer to have that feature enabled by default for it to be most useful.

@vcunat
Copy link
Member Author

@vcunat vcunat commented on ce8178e Jun 26, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, normally you don't want to check it. It's only relevant in situations like when you want to check your commit. Otherwise, doing it for whole closures of packages you touch could be rather expensive.

@copumpkin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already run a lot of other sanity checks on our derivations by default. Do you know it's going to be a significant expense?

@vcunat
Copy link
Member Author

@vcunat vcunat commented on ce8178e Jun 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking ALLOW_BROKEN in whole closure instead of on each single package (during nix-env -qa) was quite noticeable when I was testing it (part of #22277).

@vcunat
Copy link
Member Author

@vcunat vcunat commented on ce8178e Jun 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should make nixpkgs-lint or similar a part of the PR workflow (travis?).

@copumpkin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that would be nice. I hadn't seen that PR but it looks nice and helpful!

Please sign in to comment.