Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thunderbird bin 52.2.1 #26887

Merged
merged 2 commits into from Jun 28, 2017
Merged

Thunderbird bin 52.2.1 #26887

merged 2 commits into from Jun 28, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jun 27, 2017

Motivation for this change
  • Problems with Gmail (folders not showing, repeated email download, etc.) introduced in version 52.2.0.

https://www.mozilla.org/en-US/thunderbird/52.2.1/releasenotes/

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

0xABAB
0xABAB approved these changes Jun 28, 2017
View reviewed changes
Copy link
Contributor

@0xABAB 0xABAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@joachifm joachifm merged commit c7278cf into NixOS:master Jun 28, 2017
@joachifm joachifm mentioned this pull request Jun 28, 2017
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xABAB 0xABAB 0xABAB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @0xABAB @joachifm