-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HG-3 and HG-3-SL Plume Fixes #1712
Conversation
Fixing a bug found by Cosmonaut Crash on YouTube. Basically, the original plume setup didn't work for more than one engine model at a time. This fixes that, along with making the HG-3-SL and HG-3 have different plumes to acknowledge that one is a lower stage engine, the other isn't.
RealPlume Fixes for HG-3 variants
I'm confused--there's both vac and SL configs on both the vac and SL parts? |
My response to the SHIP parts was to make it so that both of the SHIP HG-3 parts used the universal config. This had the effect of making it so that you could theoretically configure the "Vacuum" model as if it were a sea level variant and vice versa. As such, plume configs would logically be necessary. Regardless, it appears that this isn't working for some reason. The SHIP parts are using the SXT plume, even though there's no reason they should be, and Cosmonaut Crash has stated that editing the .cfg using the in-game UI does nothing. So I have no *&(_ing clue what's wrong with this. |
@@ -0,0 +1,42 @@ | |||
@PART[SXTLT80]:FOR[RealPlume]:NEEDS[SmokeScreen] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong part config name, should be "RO-HG-3".
Fix part name.
Well, that fixes that small issue, but unfortunately the SHIP plumes don't work for some reason. When in the game, the engines appear to default to what appears to be the SXT plume for some reason. I'm not sure if this is something that would have been fixed by correcting the part that the SXT plume directs to, but I'm not sure. |
Alright, as far as I can tell everything is working correctly. I'll do some testing and if nothing's broken (ie. engines using wrong plumes) I think this is ready to be merged. |
@raidernick This is good for a merge. |
Making the plumes actually work for more than one engine model, and making the sea-level plume noticeably different from the vacuum plume.