-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specs for debug info output #4718
Conversation
debug %( | ||
(gdb) break foo | ||
(gdb) run | ||
(gdb) next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is required because break foo
seems to stop at spec:1
(i.e. the def
line). In #3476 this wasn't required, but it seems to be here. Is this a regression?
This works on my machine, but on travis linux |
The linux failures are because I don't have an osx machine to debug on (and due to it being apple they're very hard to get) so I think someone else will have to have a look at that. |
Looks like the docker container needs Unfortunately, this is why gdb doesn't work on osx. The instructions on how to codesign gdb appear to require using a GUI which isn't feasible. Maybe someone can experiment whether they can reliably automate this using |
37cfeb3
to
8bfe6ae
Compare
Code originally taken from waj@da7e88b and modified to compile with the current version and improve failure messages.
8bfe6ae
to
8642e75
Compare
Looks like debug info is broken on 32bits. Should we just disable the specs on 32bit or attempt to fix it? Similarly, on OSX it'll be hard to get the specs working. It seems it requires manual setup on most systems to enable gdb. We should probably disable these specs on osx by default but provide a way of enabling them for people who have a working gdb. Any thoughts on the best way to do this? A build flag? |
Sigh, that would have been fantastic, but if the solution isn't portable across systems, the benefit is dubious, for writing tests, or for developers writing/fixing them to need a specific platform :( Maybe gdb instrumentation, taking platform discrepancies into account, would perform better? |
@ysbaddaden what do you mean by "gdb instrumentation"? |
I meant opening a |
@ysbaddaden that won't help when GDB has insufficient permissions on osx and the debug info is broken on 32bit. It'd just give us the same wrong data, which would fail the specs. |
I can disable this on OSX but it's pretty clear that debug info is actually broken on 32bit here, so we should investigate that. Or should we merge this so that we can detect 64bit regressions at least? |
What's the status here, do we still want this? |
I would still love this, but it needs to be checked whether these issues are now fixed or not |
A rebased and fixed version of #3476.
Closes #3476.