Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytorch: init at 0.1.12 #27432

Closed
wants to merge 1 commit into from
Closed

pytorch: init at 0.1.12 #27432

wants to merge 1 commit into from

Conversation

teh
Copy link
Contributor

@teh teh commented Jul 16, 2017

I've only tested this on Linux and without cuda.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@teh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

FRidh
FRidh reviewed Jul 17, 2017
View reviewed changes
pkgs/development/python-modules/pytorch/default.nix Outdated
};

checkPhase = ''
bash test/run_test.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${stdenv.shell} ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pkgs/development/python-modules/pytorch/default.nix Outdated

buildInputs = [
cmake
gcc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is gcc explicitly necessary? The standard environment provides a compiler. That is not enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pkgs/development/python-modules/pytorch/default.nix Outdated
cmake
gcc
git
openblas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numpy.blas instead of openblas to make sure we use the same BLAS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@teh
Copy link
Contributor Author

teh commented Jul 17, 2017

Thanks for the review!

@FRidh
Copy link
Member

FRidh commented Jul 17, 2017

pushed 567b84d

@FRidh FRidh closed this Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teh @mention-bot @FRidh