Eclipse 4.7 oxygen: cpp & modeling #27073
Conversation
|
@jerith666, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rycee, @goetzst and @edolstra to be potential reviewers. |
|
Looks very good. I think it would be nice to keep the 4.6 expressions for a little while, but I might be alone in this opinion. |
|
I wasn't sure what the convention was -- the expressions were much more haphazard back when 4.6 came out, so it was hard to tell. Personally, I'd guess that anyone who's tracking unstable/master rather than stable is willing to have their eclipse updated pretty quickly after upstream releases. But, I'm happy to keep the 4.6 expressions if that's what you prefer. :) |
|
I think it is OK to remove the old ones, if anybody feels strongly about keeping them they are easy to resurrect. Many thanks for the contribution! Rebased into master in c3d036d. |
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)I've tested that the 64-bit versions build and launch. I've only tested that the 32-bit versions build -- launching causes errors because the surrounding GTK etc. are 64-bit.