New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i3 man & doc #27068
i3 man & doc #27068
Conversation
Some package distributions come with a flat folder containing all manpages. Those need to be put into a fixed folder structure, and `distributeManpages` does that.
@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @fpletz and @Ma27 to be potential reviewers. |
It seems a bit strange to make a whole helper for this copy task. That is the only hold-up on me merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a bit strange to make a whole helper for this copy task.
I created the helper because it’s non-trivial shell code to get right and might be useful for other packages (aka build-support
). Plus, there’s a few tests that will be included in the upcoming test suite for build-support.
for i in $(seq 0 9); do | ||
for f in $(find -name "*.$i"); do | ||
to="$outpath/man/man$i" | ||
install -D --target-directory "$to" "$f" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be -m644
.
A year later, what's the verdict? Have we seen situations where the helper would be required? Should this be merged? Though, I'm not sure the helper is right.
While I can understand the value of the helper, I'm not sure the implementation fills the role (yet). |
Personally I have no strong incentive to get this merged (I don’t use |
Motivation for this change
man pages and documentation have been missing. Introduces a helper to correctly copy manpages. See commits.