Add cmakeFlags for auto-type and yubikey #27321
Conversation
|
@sib-null, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Drakonis, @Mic92 and @s1lvester to be potential reviewers. |
| cmakeFlags = [ | ||
| "-DWITH_GUI_TESTS=ON" | ||
| "-DWITH_XC_AUTOTYPE=ON" | ||
| "-DWITH_XC_YUBIKEY=ON" |
There was a problem hiding this comment.
This requires more dependencies as described here: https://github.com/keepassxreboot/keepassxc/wiki/Building-KeePassXC#build-dependencies
| @@ -1,5 +1,5 @@ | |||
| { stdenv, fetchFromGitHub, fetchpatch, | |||
| cmake, libgcrypt, zlib, libmicrohttpd, libXtst, qtbase, qttools, libgpgerror, glibcLocales | |||
| cmake, libgcrypt, zlib, libmicrohttpd, libXtst, qtbase, qttools, libgpgerror, glibcLocales, libyubikey, libxi, libxtst, qtx11extras | |||
There was a problem hiding this comment.
They also need to be passed to buildInputs. libxi is called libXi in nixpkgs.
There was a problem hiding this comment.
Hi @Mic92, thanks for your patience with me. Finally got the LInux build building, but looks like there's some problems with the Mac build, any ideas?
There was a problem hiding this comment.
the os x failure was unrelated, keepassx-community is not targeted at this platform.
There was a problem hiding this comment.
According to keepassxc's wiki, they do have build instructions for mac, though I'm not sure how to add platform specific flags.
Regardless, after I added the release build flag and pushed again, the macOS X build passed.
There was a problem hiding this comment.
It is still unrelated, keepassx is not build on os x at the moment:
see:
platforms = with stdenv.lib.platforms; linux;
| @@ -20,7 +20,6 @@ stdenv.mkDerivation rec { | |||
| "-DWITH_GUI_TESTS=ON" | |||
| "-DWITH_XC_AUTOTYPE=ON" | |||
| "-DWITH_XC_YUBIKEY=ON" | |||
| "-DCMAKE_BUILD_TYPE=Release" | |||
There was a problem hiding this comment.
This flag is already added by default.
This is my first pull request, and I'm not a C/C++ developer at all, so I may need some guidance.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)