flashplayer: 26.0.0.131 -> 26.0.0.137 [Critical security fixes] #27315
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsix
added
1.severity: security
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://helpx.adobe.com/flash-player/release-note/fp_26_air_26_release_notes.html
https://helpx.adobe.com/security/products/flash-player/apsb17-21.html
Some tests failed. See below for details.
Things done
Tested using sandboxing
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in
./result/bin/)Fits CONTRIBUTING.md.
Built packages
nix-env -i -f . -A pkgs.flashplayernix-build -I nixpkgs=. -A pkgsi686Linux.flashplayernix-build -I nixpkgs=. -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"nix-build -I nixpkgs=. -A pkgs.flashplayer-standalonenix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debuggernix-build -I nixpkgs=. -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"Played a video with Firefox (x86_64)
Played a video with Chromium (x86_64)
Checked the version with Firefox (x86_64) http://www.adobe.com/software/flash/about/
Checked the version with Chromium (x86_64) http://www.adobe.com/software/flash/about/
Some tests failed.
flashplayer-standaloneandflashplayer-standalone-debugger(x86_64) cannot play a video like http://www.dhs.state.il.us/accessibility/tests/flash/video.swf (source: http://www.dhs.state.il.us/accessibility/tests/flash/video.html).It can play simple flash files like http://get.adobe.com/jp/flashplayer/about/flashAbout_info_small_jp.swf and http://wwwimages.adobe.com/www.adobe.com/swf/software/flash/about/flash_about_793x170.swf.
Browser plugins works well.
Please merge only browser plugins if you also cannot play those sample videos.