mergerfs: 2.16.1 -> 2.22.1 #26929
mergerfs: 2.16.1 -> 2.22.1 #26929
Conversation
| deepClone = true; | ||
| leaveDotGit = true; |
There was a problem hiding this comment.
I got a different sha256 and probably this option is the fault. Is it really required for the build?
There was a problem hiding this comment.
In fetchgit leaveDotGit is implied by deepClone anyway. I've added this line to remind me to set this flag when using nix-prefetch-git which does not behave the same way.
The different sha256 are probably because I was using nix-prefetch-git from 17.03. I've updated the hash using the latest unstable.
| }; | ||
|
|
||
| buildInputs = [ fuse pkgconfig which attr pandoc git ]; | ||
| buildInputs = [ fuse pkgconfig which attr pandoc git autoconf automake libiconv libtool gettext ]; |
There was a problem hiding this comment.
nativeBuildInputs = [ autoreconfHook pkgconfig gettext libtool git gettext pandoc which ];
buildInputs = [ fuse attr libiconv ];
There was a problem hiding this comment.
The difference between nativeBuildInputs and buildinputs is still a bit opaque for me. There is an Issue to document it #1915 but it is open for 3 years now.
Why is it better to do the split here between nativeBuildInputs and buildInputs?
There was a problem hiding this comment.
I realized that since 2.22.0 mergerfs comes bundled with fuse which is why Autoconf et al. are now necessary. This however means that the autoreconfHook cannot be applied here because mergerfs itself does not use it as it is only needed for fuse.
There was a problem hiding this comment.
@makefu native refers to the machine where the build occurs. In a cross-compilation scenario, programs executed at build time must be native to the build machine. In situations where host = build the distinction does not matter, as all inputs are native either way.
jfrankenau
force-pushed
the
mergerfs-2.22.1
branch
2 times, most recently
from
b500086 to
9495295
Compare
jfrankenau
force-pushed
the
mergerfs-2.22.1
branch
from
9495295 to
8461e31
Compare
Janik-Haag
added
the
12. first-time contribution
Motivation for this change
mergerfs: 2.16.1 -> 2.22.1
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)cc @makefu