Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: fix to work 'make help' when using Makefile.local #4641

Merged
merged 1 commit into from Jul 27, 2017
Merged

Makefile: fix to work 'make help' when using Makefile.local #4641

merged 1 commit into from Jul 27, 2017

Conversation

makenowjust
Copy link
Contributor

@makenowjust makenowjust commented Jun 30, 2017 •
edited

When using Makefile.local, make help output seems buggy:

$ touch Makefile.local
$ make help
Using /usr/local/opt/llvm/bin/llvm-config [version=4.0.1]

targets:
  Makefile        Build all files (currently crystal only) [default]
  Makefile        Clean up built directories and files
  Makefile        Clean up crystal built files
  Makefile        Run compiler specs
  Makefile        Build the compiler
  Makefile        Build dependencies
  Makefile        Generate standard library documentation
  Makefile        Show this help
  Makefile        Run all specs
  Makefile        Run standard library specs

optional variables:
  Makefile:LLVM_CONFIG llvm-config command path to use
  Makefile:debug  Add symbolic debug info
  Makefile:junit_output Directory to output junit results
  Makefile:progress Enable progress output
  Makefile:release Compile in release mode
  Makefile:stats  Enable statistics output
  Makefile:threads Maximum number of threads to use
  Makefile:verbose Run specs in verbose mode

recipes:

This reason is I assumed $MAKEFILE_LIST is expanded to single file name, but when -include Makefile.local succeed, $MAKEFILE_LIST is expanded to Makefile Makefile.local, so it is broken.

@makenowjust
Copy link
Contributor Author

I know no man is interested in Makefile, however this is simple bug fix. Please merge this...

@ysbaddaden ysbaddaden merged commit 7185965 into crystal-lang:master Jul 27, 2017
@RX14 RX14 added this to the Next milestone Jul 27, 2017
@makenowjust makenowjust deleted the fix/makefile/help-work-when-use-makefile-local branch July 27, 2017 10:08
@makenowjust
Copy link
Contributor Author

Thank you @RX14 and @ysbaddaden!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makenowjust @RX14 @ysbaddaden