Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmake files for StackOverflow Detection #2727

Merged
merged 4 commits into from Jul 1, 2017
Merged

Cmake files for StackOverflow Detection #2727

merged 4 commits into from Jul 1, 2017

Conversation

ABresting
Copy link
Contributor

some wrong commit got up in my branch so had to rebase.

Reviews addressed from the last commit -

  1. Contributors list edited,
  2. Symbol HPX_HAVE_STACKOVERFLOW_DETECTION added in place of HPX_HAVE_LIBSIGSEGV.

@hkaiser hkaiser added this to the 1.1.0 milestone Jun 30, 2017
hkaiser
hkaiser approved these changes Jul 1, 2017
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this should be added to the repository now as no other code is using this. However I'd assume that you will create more PRs relying on this functionality. So let's go ahead and merge it.

@hkaiser hkaiser merged commit 041ee3d into STEllAR-GROUP:master Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: CMake
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ABresting @hkaiser