mpd service: Create playlist directory #26990
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xABAB
reviewed
Jun 30, 2017
nixos/modules/services/audio/mpd.nix
Outdated
| @@ -126,7 +128,10 @@ in { | |||
| description = "Music Player Daemon"; | |||
| wantedBy = [ "multi-user.target" ]; | |||
|
|
|||
| preStart = "mkdir -p ${cfg.dataDir} && chown -R ${cfg.user}:${cfg.group} ${cfg.dataDir}"; | |||
| preStart = '' | |||
| mkdir -p ${cfg.dataDir} && chown -R ${cfg.user}:${cfg.group} ${cfg.dataDir} | |||
jfrankenau
force-pushed
the
mpd-create-playlistDir
branch
from
8e9ce0b to
8d4290c
Compare
jfrankenau
force-pushed
the
mpd-create-playlistDir
branch
from
8d4290c to
0dd204e
Compare
0xABAB
approved these changes
Jul 1, 2017
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently the playlist directory is hard coded in the configuration but not automatically created. Thus MPD will emit error messages and it is not possible to create playlists.
Alternatively, we could make the playlist directory an configurable option. However, then it is up to the user to make this directory read and writeable by MPD.
Things done