Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breeze-icons: generate icon cache #27458

Merged
merged 1 commit into from Jul 18, 2017
Merged

breeze-icons: generate icon cache #27458

merged 1 commit into from Jul 18, 2017

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Jul 17, 2017

Motivation

Fixes #21345 by generating the icon cache when the theme is installed.

Testing

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel
breeze-icons: generate icon cache
0d06192 
Fixes NixOS#21345 by generating the icon cache when the theme is installed.
@ttuegel ttuegel self-assigned this Jul 17, 2017
@FRidh
Copy link
Member

FRidh commented Jul 18, 2017

What if one uses other icon sets? (I don't)

@ttuegel
Copy link
Member Author

ttuegel commented Jul 18, 2017

What if one uses other icon sets? (I don't)

The default hicolor icon set is handled by the system environment builder. Other icon sets need to be handled in the same way by their maintainers. I imagine the Gnome icon themes are already treated this way.

@ttuegel ttuegel merged commit 827b0e1 into NixOS:master Jul 18, 2017
@romildo romildo mentioned this pull request Oct 8, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ttuegel ttuegel

Labels
0.kind: enhancement 6.topic: qt/kde
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttuegel @FRidh