build-fhs-userenv: Propagate $XAUTHORITY #27462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DISPLAY` environment variable is propagated into chroots built with `buildFHSUserEnv`, but currently the `XAUTHORITY` variable is not. When the latter is set, its value is usually necessary in order to connect to the X server identified by the former. This matters for users running gdm3, for example, who have `XAUTHORITY` set to something like `/run/user/1000/gdm/Xauthority` instead of the X default of `~/.Xauthority`, which doesn't exist in that setup. Fixes NixOS#21532.
|
Thanks! |
|
I also applied this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DISPLAYenvironment variable is propagated into chroots built withbuildFHSUserEnv, but currently theXAUTHORITYvariable is not. Whenthe latter is set, its value is usually necessary in order to connect to
the X server identified by the former.
This matters for users running gdm3, for example, who have
XAUTHORITYset to something like
/run/user/1000/gdm/Xauthorityinstead of the Xdefault of
~/.Xauthority, which doesn't exist in that setup.Fixes #21532.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)