nixos/lighttpd: misc improvements #27465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, seems github lists the commits in AuthorDate order, not CommitDate. So the order is wrong. Oh well. |
|
@volth: Just because I like featureful defaults. And the closure size increase (28 -> 48 MiB) didn't seem that scary to me. If you and others dislike, I can remove that commit. |
|
Yeah, I'd prefer see them continue defaulting to off. |
bjornfor
force-pushed
the
lighttpd-improvements
branch
from
0dfd679
to
22a4b49
Compare
|
I removed the I'm merging in a few days unless other comments. |
bjornfor
force-pushed
the
lighttpd-improvements
branch
from
22a4b49
to
3372580
Compare
* mod_dirlisting is auto-loaded by lighttpd and should not be explicitly loaded in the configuration file. * The rest comes from looking at "ls -1 $lighttpd/lib/*.so" when lighttpd is built with "enableMagnet" and "enableMysql".
Place them in $out/share/lighttpd/doc/config/. Most importantly, this includes a complete set of mime types in the $out/share/lighttpd/doc/config/conf.d/mime.conf file. The plan is to use that file in the NixOS lighttpd module.
enableUpstreamMimeTypes controls whether to include the list of mime types bundled with lighttpd (upstream). This option is enabled by default and gives a much more complete mime type list than we currently have. If you disable this, no mime types will be added by NixOS and you will have to add your own mime types in services.lighttpd.extraConfig.
bjornfor
force-pushed
the
lighttpd-improvements
branch
from
3372580
to
aff0725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Mostly to get full mimetype list from upstream, but also misc improvements. See commits.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)