osquery: init at 2.5.2 #27347
osquery: init at 2.5.2 #27347
Conversation
|
This currently builds the SDK as a static library, while it would be nice to instead provide a shared library. Unfortunately, when I add: ${if (!enableStatic) then "OSQUERY_BUILD_SHARED" else null} = true;
${if (!enableStatic) then "BUILD_LINK_SHARED" else null} = true;I get the following compile error: |
| wantedBy = [ "multi-user.target" ]; | ||
| path = [ pkgs.osquery ]; | ||
| preStart = '' | ||
| mkdir -p ${escapeShellArg cfg.loggerPath} |
There was a problem hiding this comment.
escapeShellArg will not add quotes around the argument. You have to add them manually.
There was a problem hiding this comment.
That's not what it looks like:
nix-repl> lib.escapeShellArg "this is a test"
"'this is a test'"
Note, specifically, the inner single quotes (').
| GENTOO_RELEASE = "/etc/gentoo-release" | ||
|
|
||
| def _platform(): | ||
| + return ("nixos", "nixos") |
There was a problem hiding this comment.
To bad that they have no support for /etc/os-release. The only disadvantage of this patch is, that it won't work on non-nixos. Also I don't how many people would use osqueryd that way.
| else() | ||
| set(LINUX TRUE) | ||
| - set(CXX_COMPILE_FLAGS "${CXX_COMPILE_FLAGS} -std=c++14 -stdlib=libstdc++") | ||
| + set(CXX_COMPILE_FLAGS "${CXX_COMPILE_FLAGS} -std=c++14") |
There was a problem hiding this comment.
What was the problem with libstdc++ in nixos? It might also helpful to add a comment so future maintainer have an easier job.
There was a problem hiding this comment.
@Mic92 I get: g++: error: unrecognized command line option '-stdlib=libstdc++'
The osquery devs build their stuff with clang, where that flag makes sense.
There was a problem hiding this comment.
Do think we could run into subtle runtime bugs due not using clang++ on nixos?
There was a problem hiding this comment.
No; we're not mixing different standard libs, so everything should be fine.
|
I've further split-up the commits (factoring out |
|
I think this is fairly uncontroversial; merging. |
Motivation for this change
I'd like to use osquery: https://osquery.io/
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)The
osqueryddaemon can be configured in NixOS like so:As time goes by, we can try to expand the support for legitimate configuration options, but that's out of scope for this PR; for now,
extraConfigprovides an escape hatch (we'll want this anyway, since the config file schema is large, and we'll undoubtedly provide only subset as direct NixOS options at any given moment; we should allow people to easily express the config settings in the interim). The settings inextraConfigare merged recursively, so separate NixOS config files can specify separate schedules, packs, etc.