Fix chained comparisons to_s to work #4663
#4708
Merged
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ASTNode of `1 <= 2 <= 3` is `to_s`-ed to `(1 <= 2) <= 3`. Right side parenthesis is not required and it causes crystal-lang#4653 error.
|
Is this getting looked at? @RX14 or @matiasgarciaisaia :) |
RX14
approved these changes
Jul 31, 2017
RX14
added
kind:bug
straight-shoota
pushed a commit
to straight-shoota/crystal
that referenced
this pull request
Aug 11, 2017
…g#4708) Fix to work crystal-lang#4663 The ASTNode of `1 <= 2 <= 3` is `to_s`-ed to `(1 <= 2) <= 3`. Right side parenthesis is not required and it causes crystal-lang#4653 error.
Val
pushed a commit
to Val/crystal
that referenced
this pull request
Aug 12, 2017
…g#4708) Fix to work crystal-lang#4663 The ASTNode of `1 <= 2 <= 3` is `to_s`-ed to `(1 <= 2) <= 3`. Right side parenthesis is not required and it causes crystal-lang#4653 error.
makenowjust
added a commit
to makenowjust/crystal
that referenced
this pull request
Aug 19, 2017
This fixes `ToSVisitor` uses parent node information to decide to wrap receiver with parens (so we can detect chained comparison correctly!) `to_s` with `1 <= 2 <= 3` AST yields itself, and now `to_s` with `(1 <= 2).as(Bool)` AST yields itself too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4663
The ASTNode of
1 <= 2 <= 3isto_s-ed to(1 <= 2) <= 3. Right side parenthesis is not required and it causes #4653 error.