Rename skip() macro method to skip_file() #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. It follows discussions #4675 (comment) and #4686 |
There was a miscommunication in the macro's name when implementing Crystal::System, meaning that skip_file was used but the method was implemented as skip. In addition, add parens to skip_file to make it parse as a function call.
RX14
force-pushed
the
feature/rename-skip
branch
from
7d75cc9
to
d1b10e2
Compare
straight-shoota
pushed a commit
to straight-shoota/crystal
that referenced
this pull request
Aug 11, 2017
There was a miscommunication in the macro's name when implementing Crystal::System, meaning that skip_file was used but the method was implemented as skip. In addition, add parens to skip_file to make it parse as a function call.
Val
pushed a commit
to Val/crystal
that referenced
this pull request
Aug 12, 2017
There was a miscommunication in the macro's name when implementing Crystal::System, meaning that skip_file was used but the method was implemented as skip. In addition, add parens to skip_file to make it parse as a function call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a miscommunication in the macro's name when implementing Crystal::System, meaning that skip_file was used but the method was implemented as skip. In addition, add parens to skip_file to make it parse as a function call.