Bump slurm, add pyslurm #27350
Bump slurm, add pyslurm #27350
Conversation
|
@veprbl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jagajaga, @rickynils, @mitchty and @FRidh to be potential reviewers. |
pkgs/top-level/python-packages.nix
Outdated
| @@ -22378,6 +22378,29 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| pyslurm = buildPythonPackage rec { | |||
There was a problem hiding this comment.
Can you add only a reference to this file and move the actual expression to a dedicated file python-modules as describe in header of this file?
There was a problem hiding this comment.
Do you want me to move definition to pkgs/development/python-modules/pyslurm/default.nix because there is a patch?
There was a problem hiding this comment.
No. We do this for all new python packages and for most updated ones, due the size of this file.
| substituteInPlace ./doc/html/shtml2html.py --replace "/usr/bin/env python" "${python.interpreter}" | ||
| substituteInPlace ./doc/man/man2html.py --replace "/usr/bin/env python" "${python.interpreter}" | ||
| patchShebangs ./doc/html/shtml2html.py | ||
| patchShebangs ./doc/man/man2html.py |
There was a problem hiding this comment.
Solution is ok. Often I just prefer the shotgun method and use patchShebangs . to avoid future shebangs maintenance.
| }; | ||
|
|
||
| outputs = [ "out" "dev" ]; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig ]; | ||
| # nixos test fails to start slurmd with 'undefined symbol: slurm_job_preempt_mode' | ||
| # https://groups.google.com/forum/#!topic/slurm-devel/HiltSkNiGJU |
There was a problem hiding this comment.
Are you sure this was the correct link? The thread mentions something about removing "-O0" from CFLAGS.
| @@ -0,0 +1,18 @@ | |||
| diff --git a/pyslurm/__init__.py b/pyslurm/__init__.py | |||
There was a problem hiding this comment.
Can you also send this patch upstream?
|
Thanks! |
|
@Mic92 Thank you! |
|
|
||
| slurm-llnl-full = appendToName "full" (callPackage ../servers/computing/slurm { }); |
Motivation for this change
I needed pyslurm client which is based on slurm version from 2017, so hence the version bump.
I don't use nixos or daemon, but I've tried to look at the test that was broken even before. The problem seems to be that slurmd wouldn't start. I fixed that, so now
nix-build ./nixos/tests/slurm.nixproduces an output path. So, I guess, it's fixed?Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)