Skip to content

Jenkinsfile-vim-syntax: init #27232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2017
Merged

Jenkinsfile-vim-syntax: init #27232

merged 1 commit into from
Jul 9, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jul 8, 2017

Motivation for this change

To edit Jenkinsfiles I need a plugin which supports syntax highlighting for such files.

I checked the configuration using the following nix expression:

# vimtest.nix
with import <nixpkgs>{};

pkgs.vim_configurable.customize {
  name = "vimtest";
  vimrcConfig.vam.pluginDictionaries = [
    { name = "Jenkinsfile-vim-syntax"; }
  ];
}

I tested the configuration using the following command:

NIX_PATH=nixpkgs=$HOME/Projects/nixpkgs/ nix-build vimtest.nix
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.


};

deoplete-rust = buildVimPluginFrom2Nix { # created by nix#NixDerivation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that somebody forgot to add this to the name list.

@Ma27
Copy link
Member Author

Ma27 commented Jul 9, 2017

@Mic92 fixed. (should I revert the squash to make bisecting easier or is one commit for both changes fine?)

@Mic92 Mic92 merged commit f939630 into NixOS:master Jul 9, 2017
@Mic92
Copy link
Member

Mic92 commented Jul 9, 2017

this is fine.

@Ma27 Ma27 deleted the init/jenkinsfile-vim-support branch July 9, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants