kbd: fix unicode_start and unicode_stop scripts #27248
Closed
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therealpxc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @abbradar and @wkennington to be potential reviewers. |
|
Ah, you noticed the error too? The thing is I fixed this already a while back but the change somehow never made it into master. See #22793 |
|
I just looked into it yesterday, because I decided to try to get all the error messages out of fish init because I was looking at it in the course of testing for that other stuff we were both working on. I don't normally see those error messages, because I use the tmux-zen plugin for oh-my-fish. I felt guilty for ignoring them just because I usually don't see them, lol. I didn't see your work when I made this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
previously, the
unicode_startandunicode_stopscripts were looking for thettycommand in/usr/bin/tty, which means they could never run successfully on NixOSThings done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)