lrexlib: 2.7.2 (broken) -> 2.8.0 #27243
Conversation
|
@richardipsum, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Wyvie, @vcunat and @k0ral to be potential reviewers. |
pkgs/top-level/lua-packages.nix
Outdated
| }; | ||
| buildInputs = [ unzip luastdlib pcre luarocks oniguruma gnulib tre glibc ]; | ||
|
|
||
| buildPhase = let | ||
| luaVariable = "LUA_PATH=${luastdlib}/share/lua/${lua.luaversion}/?.lua"; | ||
| luaVariable = "LUA_PATH=\"${luastdlib}/share/lua/${lua.luaversion}/?/init.lua;${luastdlib}/share/lua/${lua.luaversion}/?.lua\""; |
There was a problem hiding this comment.
Using double single quotes (see nix syntax) would allow you to get rid of the escaping business, which is distracting.
There was a problem hiding this comment.
wow, thanks for such a speedy review, will swap for double single quotes now 😸
There was a problem hiding this comment.
@richardipsum Don't get your hopes up; my opinion does not matter in this project, since I am only a "Contributor".
Thanks for your contribution.
richardipsum
force-pushed
the
richardipsum/fix-lrexlib
branch
from
6f7ff4c to
945c02a
Compare
pkgs/top-level/lua-packages.nix
Outdated
| }; | ||
| buildInputs = [ unzip luastdlib pcre luarocks oniguruma gnulib tre glibc ]; | ||
|
|
||
| buildPhase = let | ||
| luaVariable = "LUA_PATH=${luastdlib}/share/lua/${lua.luaversion}/?.lua"; | ||
| luaVariable = ''LUA_PATH="${luastdlib}/share/lua/${lua.luaversion}/?/init.lua;${luastdlib}/share/lua/${lua.luaversion}/?.lua"''; | ||
|
|
||
| pcreVariable = "PCRE_DIR=${pcre.dev}"; |
There was a problem hiding this comment.
The reason this isn't building the rex_pcre.so seems to be due to this depending on pcre.dev, which doesn't contain the lib needed, I will rework this.
There was a problem hiding this comment.
Yeah, this needs to use both pcre.dev for the header files, and pcre.out for the shared object, I'll push this fix shortly.
The shared objects are not available in 'pcre.dev', so to build the rex_pcre.so file we must specify 'pcre.out' as the directory to obtain shared objects from, 'pcre.dev' is still needed for the header files though.
richardipsum
force-pushed
the
richardipsum/fix-lrexlib
branch
from
945c02a to
32dec43
Compare
|
@7c6f434c Please merge. |
Hello,
This fixes a previously broken package. The package now builds for both lua5.1 and lua5.2 on GNU/Linux. I have checked the resulting output for the presence of the expected shared objects, the rex_pcre.so object is missing, but that looks to be due to a possibly broken pcre package.
Hope this helps,
Richard Ipsum