CMake for Stack Overflow Detection #2726
Conversation
cmake/FindLibSigSegv.cmake
Outdated
| # Copyright (c) 2014 Thomas Heller | ||
| # Copyright (c) 2007-2012 Hartmut Kaiser | ||
| # Copyright (c) 2010-2011 Matt Anderson | ||
| # Copyright (c) 2011 Bryce Lelbach |
There was a problem hiding this comment.
I doubt that all the people here contributed to this file...
There was a problem hiding this comment.
Does your suggestion count?
There was a problem hiding this comment.
Nah, copyright belongs to the people writing the code.
CMakeLists.txt
Outdated
| endif() | ||
| hpx_libraries(${LIBSIGSEGV_LIBRARIES}) | ||
| include_directories(${LIBSIGSEGV_INCLUDE_DIR}) | ||
| hpx_add_config_define(HPX_HAVE_LIBSIGSEGV) |
There was a problem hiding this comment.
Please use the 'same' symbol as you used for the configuration. Normally, for a configuration variable HPX_WITH_FOO we use the preprocessor constant HPX_HAVE_FOO. In this case this would be HPX_HAVE_STACKOVERFLOW_DETECTION.
ABresting
force-pushed
the
master
branch
2 times, most recently
from
2dbf2f9
to
00a2072
Compare
|
@ABresting: why did you close this and reopen in a separate PR? You can just keep (force-) pushing to the branch and it will update the corresponding PR. |
|
accidentally rebased one of the older commits, did't want to make any conflict. Saw those commits were lost so made a clean PR. |
|
@hkaiser to test the libsigsegv wrapper, should I write a test? |
You could have force-pushed to the original branch. That would have fixed it as well. |
Absolutely! Please do! |
No description provided.