Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skrooge: 2.7.0 -> 2.8.1 #26849

Merged
merged 1 commit into from Jun 26, 2017
Merged

skrooge: 2.7.0 -> 2.8.1 #26849

merged 1 commit into from Jun 26, 2017

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 25, 2017

Motivation for this change

Upstream update.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I put shared_mime_info in nativeBuildInputs. I’m not sure if this is correct.

@mention-bot
Copy link

@vbgl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel and @urkud to be potential reviewers.

@FRidh FRidh merged commit 9dbfd87 into NixOS:master Jun 26, 2017
@vbgl vbgl deleted the skrooge-2.8 branch September 4, 2017 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vbgl @mention-bot @fpletz @joachifm @FRidh