Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security-wrapper: run activation script after specialfs #26854

Merged
merged 1 commit into from Jun 26, 2017
Merged

security-wrapper: run activation script after specialfs #26854

merged 1 commit into from Jun 26, 2017

Conversation

4z3
Copy link
Contributor

@4z3 4z3 commented Jun 25, 2017

Motivation for this change

Ensures that parentWrapperDir exists before it is used.

Closes #26851

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@4z3
security-wrapper: run activation script after specialfs
6505174 
Ensures that parentWrapperDir exists before it is used.

Closes NixOS#26851
@mention-bot
Copy link

@4z3, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ixmatus, @globin and @abbradar to be potential reviewers.

@fpletz fpletz merged commit ea44ca4 into NixOS:master Jun 26, 2017
@4z3 4z3 deleted the wrappers-after-specialfs branch June 26, 2017 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@4z3 @mention-bot @fpletz