mpv: eliminate config.mpv options
#26865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing all `config.mpv.*` options will improve readability. MPV has many configurable options, and using the config approach is prone to confusion and unnecessary code duplication. If needed, the user can `override` the relevant variables in the function itself, so no functionality is lost. Closes issue #26786
|
Being a co-maintainer of mpv: 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all
config.mpv.*options will improve readability. MPV has manyconfigurable options, and using the config approach is prone to confusion and
unnecessary code duplication. If needed, the user can
overridethe relevantvariables in the function itself, so no functionality is lost.
"Closes" issue #26786 (many thanks @tdjikini !)
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)