Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-gflags: 2.0 -> 3.1.1 #26858

Merged
merged 3 commits into from Jun 28, 2017
Merged

python-gflags: 2.0 -> 3.1.1 #26858

merged 3 commits into from Jun 28, 2017

Conversation

benley
Copy link
Member

@benley benley commented Jun 25, 2017

Motivation for this change

gflags doesn't work with python 3 until version 3.1

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Jun 26, 2017
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -11607,15 +11607,17 @@ in {


gflags = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also move this expression to python-modules?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done

@Mic92
Copy link
Member

Mic92 commented Jun 26, 2017 •
edited

We have quite a few applications require gflags.
It might make sense to keep both major releases 2.x and 3.x, because of breaking changes:
https://github.com/google/python-gflags/blob/master/ChangeLog#L66

This means I have not tested, if our packages also support the new version.

FRidh
FRidh requested changes Jun 26, 2017
View reviewed changes
pkgs/development/python-modules/gflags/default.nix Outdated
pname = "python-gflags";
sha256 = "0qvcizlz6r4511kl4jlg6fr34y1ka956dr2jj1q0qcklr94n9zxa";
};
propagatedBuildInputs = [ six pytest ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py.test shouldn't be propagated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, oversight.

@FRidh FRidh merged commit 1856119 into NixOS:master Jun 28, 2017
@benley benley deleted the python-gflags-3.1.1 branch July 3, 2017 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benley @Mic92 @FRidh @joachifm