New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial import of valarray serializer #2714
Conversation
Chris: thanks for submitting this!
|
Anytime! Hoping this is the beginning of future contributions with a fair bit more complexity. Will begin making the requested modifications, thank you for the opportunity to contribute! |
The unit test is a copy+paste+modification of the std::array unit test. |
@ct-clmsn: The test will run only if it was added to the |
@hkaiser thank you for the reminder! |
|
||
template<typename T> | ||
void serialize(hpx::serialization::output_archive &ar, | ||
const std::valarray<T> arr, int /* version */) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chris, sorry for still having something to complain about... Here, arr
should be passed by const&
to avoid unnecessary copying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a problem, got a bit caught up sorting out text formatting issues. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks a lot!
Chris: congrats to your first merged PR! This qualifies you for a STE||AR-Group T-shirt ;) |
@hkaiser you are too kind! thank you for the support and the opportunity! |
serializer for std::valarray