Minio service #26848
Merged
Minio service #26848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a simple test for the service |
Mic92
reviewed
Jun 25, 2017
| mkdir -p ${cfg.configDir} | ||
| chown -R minio:minio ${cfg.configDir} | ||
| mkdir -p ${cfg.dataDir} | ||
| chown -R minio:minio ${cfg.dataDir} |
There was a problem hiding this comment.
Is not this an expensive operation, if dataDir contains a lot of files? It also defeats the necessity to allocate static uid/gid numbers.
There was a problem hiding this comment.
@Mic92 You are right, the puprose was to create the data directory if it doesn't already exists.
But I think a chown without -R would be sufficient. I will change that.
features: - change listen port and address - configure config and data directory - basic test to check if minio server starts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add a service to run a basic minio server.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)