Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: smoltcp-rs/smoltcp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b3e355437f68
Choose a base ref
...
head repository: smoltcp-rs/smoltcp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ac6efbf99945
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Jun 26, 2017

  1. In examples, print packet dumps with timestamps, too. 

    This helps debugging retransmit issues.
    @whitequark
    whitequark committed Jun 26, 2017
    Copy the full SHA
    86c1cba View commit details

  2. In examples, trace the packets being dropped by the fault injector.

    @whitequark
    whitequark committed Jun 26, 2017
    Copy the full SHA
    a2f233e View commit details

  3. Try to trigger fast retransmit when we detect a missing TCP segment. 

    The changes in this commit affect the following scenario:
  * Remote end sends octets 1..2, they are delivered and buffered
    on local end;
  * Remote end sends octets 3..4, they are lost;
  * Remote end sends octets 5..6, they are delivered but cannot
    be buffered on local end because we don't perform reassembly.

Before this commit, we would silently drop the segment with octets
5..6, relying on retransmission timer on the remote end. This works,
but can result in severe decrease in throughput. After this commit,
we send a duplicate ACK, which may trigger fast retransmit, if
implemented by the congestion control algorithm on the remote end.
    @whitequark
    whitequark committed Jun 26, 2017
    Copy the full SHA
    ac6efbf View commit details
Loading