-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
[wip] docker: 17.03.2-ce -> 17.06.0-ce #27137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc @offlinehacker @NeQuissimus 👼 |
containerdRev = "9048e5e50717ea4497b757314bad98ea3763c145"; | ||
containerdSha256 = "1r9xhvzzh7md08nqb0rbp5d1rdr7jylb3da954d0267i0kh2iksa"; | ||
docker_17_06 = dockerGen rec { | ||
version = "17.06.0-ce-rc2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't want RC2, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NeQuissimus oh right, didn't update that yet.. was trying to figure out the errors before 😛
export VERSION="${version}" | ||
source ./scripts/build/.variables | ||
export CGO_ENABLED=1 | ||
go build -tags pkcs11 --ldflags "$LDFLAGS" github.com/docker/cli/cmd/docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am glad you did this, I hate figuring out GO things :D
I got it, I think :) I don't seem to be able to post commits into here, so here is the diff you need to apply, @vdemeester That weird error you were seeing was because
|
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
5f7c605
to
ec57044
Compare
@NeQuissimus thanks a lot ! Updated and it is working 🌥 😎 👍. Also updated the man generation stuff. |
Signed-off-by: Vincent Demeester vincent@sbr.pm
Motivation for this change
Release of
docker-ce
happened and the repository where the release happens has changed 😅 …It's still a
WIP
containerd
(probably elsewhere)Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)