Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-fame: init at 2.5.2 #27145

Closed
wants to merge 2 commits into from
Closed

git-fame: init at 2.5.2 #27145

wants to merge 2 commits into from

Conversation

expipiplus1
Copy link
Contributor

@expipiplus1 expipiplus1 commented Jul 5, 2017 •
edited

If some ruby boffin could help with this that would be super. At the moment the
git-fame binary doesn't end up in /bin. calling
/nix/store/jxq90d7jlfj1d457lkasmi03g9l0vykh-ruby2.3.3-git_fame-2017-01-14/lib/ruby/gems/2.3.0/bundler/gems/git-fame-rb-64748dfb18b0/bin/git-fame
works however.

@joachifm
Copy link
Contributor

joachifm commented Jul 9, 2017

cc @zimbatm @Mic92 re ruby packaging

zimbatm
zimbatm reviewed Jul 10, 2017
View reviewed changes
pkgs/applications/version-management/git-and-tools/git-fame/gemset.nix Outdated
rev = "64748dfb18b0a892e8b01483a5ebc5282c594a5d";
sha256 = "1vmhnmwp5l5d1k7syfn6p2nlqa59schkzzlk7xk2khzc5xzq18zf";
type = "git";
url = "git://github.com/oleander/git-fame-rb.git";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to use a git version, is release v2.5.2 too old?

zimbatm
zimbatm reviewed Jul 10, 2017
View reviewed changes
pkgs/applications/version-management/git-and-tools/git-fame/default.nix Outdated
inherit ruby;
gemdir = ./.;

pname = "git_fame";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's possible that setting both the name and pname doesn't interact very well. If the ruby gem is called "git_fame" then it's better to name the package the same way.

zimbatm
zimbatm reviewed Jul 10, 2017
View reviewed changes
pkgs/applications/version-management/git-and-tools/git-fame/Gemfile Outdated
source 'https://rubygems.org'

# Specify your gem's dependencies in git_fame.gemspec
gemspec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something's missing here. It should be gem "git_fame"

@Mic92 Mic92 changed the title git-fame: Init at 2017-01-14 git-fame: init at 2017-01-14 Jul 10, 2017
@expipiplus1 expipiplus1 changed the title git-fame: init at 2017-01-14 git-fame: init at 2.5.2 Aug 7, 2017
@expipiplus1
Copy link
Contributor Author

@zimbatm I've applied your changes, however running $(nix-build --no-out-link -A gitAndTools.git-fame)/bin/git-fame doesn't work; running $(nix-build --no-out-link -A gitAndTools.git-fame)/lib/ruby/gems/2.3.0/gems/git_fame-2.5.2/bin/git-fame does though

$ $(nix-build --no-out-link -A gitAndTools.git-fame)/bin/git-fame
/nix/store/3d7a11zliyy2djcphlq5mx6rr1yxlll3-bundler-1.14.6/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/rubygems_integration.rb:408:in `block in replace_bin_path': can't find executable git-fame (Gem::Exception)
        from /nix/store/3d7a11zliyy2djcphlq5mx6rr1yxlll3-bundler-1.14.6/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/rubygems_integration.rb:434:in `block in replace_bin_path'
        from /nix/store/86ahl0dm6j72f34rh191dafp8jhda9kp-git-fame-2.5.2/bin/git-fame:18:in `<main>'

@zimbatm
Copy link
Member

zimbatm commented Aug 8, 2017

@expipiplus1 yeah there's something wrong with the ruby env. I've pushed a little change but it doesn't fit the main issue.

@Mic92
Copy link
Member

Mic92 commented Aug 9, 2017

fixed in 531a5b1
Gemfile was not correctly updated.

@Mic92 Mic92 closed this Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm left review comments

Assignees
No one assigned
Labels
6.topic: ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@expipiplus1 @joachifm @zimbatm @Mic92 @FRidh