mpd service: Start when needed and harden #27055
Conversation
|
@jfrankenau, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rickynils, @dmalikov and @unaizalakain to be potential reviewers. |
nixos/modules/services/audio/mpd.nix
Outdated
| listenStreams = [ | ||
| "/run/mpd/socket" | ||
| "${cfg.network.listenAddress}:${toString cfg.network.port}" | ||
| ]; |
There was a problem hiding this comment.
Just to be sure: Did you test that mpd pick up multiple sockets, when passed via socket activation?
There was a problem hiding this comment.
I have now and the upstream MPD socket file does the same. I decided to use /var/run/mpd/socket to use the same location MPD uses.
While testing I noticed that any for listenAddress needed to be handled with care in the systemd socket file which is fixed now.
There was a problem hiding this comment.
This is more of a general problem, but hardcoding "/run/mpd/socket" here and in other places is a not a modular solution.
It means that if I later want to add another service which is also called mpd, but does something completely different that I need to care about the existence of this particular service; something a well designed system would not require.
There was a problem hiding this comment.
You are right. I have removed the IPC socket for now. I couldn't find a client where the default is set to a local socket anyway. In the future we could add an option which allows to specify a path for it but I guess most people never even thought about using one.
jfrankenau
force-pushed
the
mpd-startWhenNeeded
branch
from
5ed09fa to
e4b8633
Compare
jfrankenau
force-pushed
the
mpd-startWhenNeeded
branch
from
e4b8633 to
c4528eb
Compare
Motivation for this change
By using a systemd socket it is possible to start MPD only when it's needed similar to the OpenSSH daemon config option
startWhenNeeded.Additionally, upstream provides a hardened systemd service file which I've integrated here. This also fixes two error messages from MPD regarding real-time priority and Avahi.
Things done