Skip to content

libreoffice: remove spadmin wrapper #27023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2017
Merged

Conversation

emmanuelrosa
Copy link
Contributor

This change removes the spadmin wrapper because the utility was removed from LibreOffice in release 4.3. See https://wiki.documentfoundation.org/ReleaseNotes/4.3#CUPS.2C_fax_machines_and_spadmin which states:

The graphical utility spadmin is now removed in favor of these new features and the operating system's standard printer administration tools. (Caolán McNamara)

Closes #26671

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
mcollina Matteo Collina
This change removes the spadmin wrapper because the utility was removed from LibreOffice in release 4.3. See https://wiki.documentfoundation.org/ReleaseNotes/4.3#CUPS.2C_fax_machines_and_spadmin which states:

 > The graphical utility spadmin is now removed in favor of these new features and the operating system's standard printer administration tools. (Caolán McNamara)

 Closes NixOS#26671
@mention-bot
Copy link

@emmanuelrosa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel, @7c6f434c and @domenkozar to be potential reviewers.

@joachifm
Copy link
Contributor

joachifm commented Jul 1, 2017

cc @7c6f434c

@7c6f434c 7c6f434c merged commit 26f47d1 into NixOS:master Jul 1, 2017
@emmanuelrosa emmanuelrosa deleted the spadmin branch July 1, 2017 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants