splix: enable JBIG #27027
Merged
splix: enable JBIG #27027
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables JBIG given that according to OpenPrinting.org, the patents have expired. See https://www.openprinting.org/driver/splix/license/ Closes NixOS#25929
|
@emmanuelrosa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @urkud and @zimbatm to be potential reviewers. |
|
Ahh, I didn't check whether you tested it. Did you test it? |
|
I attempted to, but the build never completed. Make and g++ ran, but even after running for a couple of hours no output was produced. Interestingly, I couldn't find any object files in the build's tmp directory. I don't know what was going on. |
|
I'm trying the build again. I'm baffled as to why so little C++ code would need more computation time to compile, but I'm giving it a go. |
8 tasks
|
Perhaps it needs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables JBIG given that according to OpenPrinting.org, the patents have expired.
See https://www.openprinting.org/driver/splix/license/
Closes #25929
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)