fzf: Include fzf shell scripts in output #27058
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xABAB
reviewed
Jul 2, 2017
| @@ -39,6 +39,7 @@ buildGoPackage rec { | |||
| cp -r $src/man/man1 $man/share/man | |||
| mkdir -p $out/share/vim-plugins | |||
| ln -s $out/share/go/src/github.com/junegunn/fzf $out/share/vim-plugins/${name} | |||
| cp -R $src/shell $out/share/shell | |||
There was a problem hiding this comment.
Could you not be a dick and make a sentence please ?
|
Note that |
binarin
pushed a commit
to binarin/nixpkgs
that referenced
this pull request
Jul 28, 2017
So that helper scripts can be easily sourced in interactive shell configuration. `autojump` package was already present and had the same requirements for findind a `share` folders, so I took an inspiration there. I beleive this is a better alternative to: - NixOS#25080 - NixOS#27058 Replacing `$out/share/shell` with `$bin/share/fzf` was necessary to prevent dependency loop in produced derivations.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fzfprovides some useful shell scripts to setup key bindings and completion for various shells (https://github.com/junegunn/fzf/tree/master/shell).Those scripts were previously unaccessible from the built package.
This PR makes those scripts accessible from
${fzf.out}/share/shell, alongside the vim plugin.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)