Skip to content

bitlbee service: Add option to load libpurple plugins into bitlbee #27057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2017

Conversation

Nadrieril
Copy link
Member

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@Nadrieril, thanks for your PR! By analyzing the history of the files in this pull request, we identified @4z3, @pSub and @edolstra to be potential reviewers.

@@ -25,6 +29,13 @@ let
${cfg.extraDefaults}
'';

purple_plugin_path =
builtins.concatStringsSep ":" (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using concatMapStringsSep

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thx for the suggestion

Verified

This commit was signed with the committer’s verified signature.
globin Robin Gloster
@Nadrieril Nadrieril force-pushed the bitlbee-libpurple branch from 20d6ceb to 65e38b7 Compare July 16, 2017 13:20
@Mic92
Copy link
Member

Mic92 commented Jul 17, 2017

@makefu @4z3 are you interested in testing this?

@makefu
Copy link
Contributor

makefu commented Jul 17, 2017

@Mic92 will do! I will test telegram-purple and see how far i can get

@Nadrieril
Copy link
Member Author

BTW I've been using it with purple-hangouts for a few months and it works very well.

@makefu
Copy link
Contributor

makefu commented Jul 17, 2017

@Mic92 @Nadrieril i've tested the module (via cherry-picking on my private nixpkgs unstable) with telegram-purple and everything works as expected. Thanks a lot, i was waiting for this feature for a long time.

@Nadrieril
Copy link
Member Author

All the thanks go to @regnat, he was the one who wrote the code. I'm just trying to merge it since he is not interested anymore.

@Mic92 Mic92 merged commit 04c944c into NixOS:master Jul 17, 2017
@Nadrieril Nadrieril deleted the bitlbee-libpurple branch February 10, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants