rustc: Provide unpacked source tree derivation for use in tools #27026
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xABAB
approved these changes
Jul 1, 2017
|
I'm not really happy with the unpacking derivation. It seems like something that would have existed elsewhere by now, but I couldn't find anything to share it with. Edit: What I mean is, should there be a helper to unpack src to $out? |
0xABAB
reviewed
Jul 1, 2017
| mkdir -p $out | ||
| cp -r . $out/ | ||
| ''; | ||
| phases = [ "unpackPhase" "installPhase" ]; |
There was a problem hiding this comment.
Various people don't like setting phases like this. You can skip a phase by setting it to ":" (a command which does the same as the command true).
Racer doesn't function when RUST_SRC_PATH points to the source tarball.
|
Fixed in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Racer doesn't function when RUST_SRC_PATH points to the source tarball.
I chose
unpackedSrcinstead ofsrcto avoid any possibly breakage, but perhaps it's better to replacesrc? It could also be made an additional output of the rustc derivation instead.Any thoughts?
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)