Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: fix the drmSupport option #27025

Merged
merged 1 commit into from
Jul 16, 2017
Merged

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Jul 1, 2017

At some point the config flag must have changed from --enable-eme to
--enable-eme=widevine, so it was having no effect.

I was trying to get Spotify to work, when I noticed that drmSupport = true didn't actually enable EME. The Spotify player now loads, but I still don't actually get audio, even though the song appears to be playing. I've tried with and without pulseaudio support in the wrapper.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

At some point the config flag must have changed from --enable-eme to
--enable-eme=widevine, so it was having no effect.
@mention-bot
Copy link

@corngood, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oxij, @edolstra and @vcunat to be potential reviewers.

@grahamc grahamc merged commit 7fcddfe into NixOS:master Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants