heartbeat service: init #27019
heartbeat service: init #27019
Conversation
|
@fadenb Are you going to be the maintainer of this service? |
|
As I plan to use it extensively: Yes :) |
| mkdir -p ${cfg.stateDir}/data | ||
| mkdir -p ${cfg.stateDir}/logs | ||
| ''; | ||
| serviceConfig = { |
There was a problem hiding this comment.
Does the program implement its own privsep or does it end up running with full privileges?
There was a problem hiding this comment.
@joachifm heartbeat documentation ( https://www.elastic.co/guide/en/beats/heartbeat/current/configuration-heartbeat-options.html#monitor-type ) states that root is required for icmp type monitors but it seems to be working fine with a "cap_net_raw+p" wrapper. I will change the PR accordingly
| wantedBy = [ "multi-user.target" ]; | ||
| preStart = '' | ||
| mkdir -p ${cfg.stateDir}/data | ||
| mkdir -p ${cfg.stateDir}/logs |
There was a problem hiding this comment.
Replace with this exact code: mkdir -p "${cfg.stateDir}"/{data,logs}
| mkdir -p ${cfg.stateDir}/logs | ||
| ''; | ||
| serviceConfig = { | ||
| ExecStart = "${pkgs.heartbeat}/bin/heartbeat -c ${heartbeatYml} -path.data ${cfg.stateDir}/data -path.logs ${cfg.stateDir}/logs"; |
| wantedBy = [ "multi-user.target" ]; | ||
| preStart = '' | ||
| mkdir -p "${cfg.stateDir}"/{data,logs} | ||
| chown nobody "${cfg.stateDir}"/{data,logs} |
There was a problem hiding this comment.
Also set the group explicitly.
|
@fadenb Thanks for the feedback and your changes |
|
Thank you |
Motivation for this change
This is basically a copy of the existing journalbeat service by @mbrgm allowing quick and easy setup of elastic heartbeat.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)