Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.codecov: init at 2.0.9 #27018

Merged
merged 2 commits into from
Jul 3, 2017
Merged

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Jul 1, 2017

Motivation for this change

I added this package because the tests for MarkdownSuperscripts (see #26985) depend on it.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@Zimmi48, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this package because the tests for MarkdownSuperscripts (see #26985) depend on it.

Its fine adding such dependencies in the same PR as separate commits.


propagatedBuildInputs = [ requests coverage ];

patchPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postPatch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I'll change this.

meta = {
description = "Python report uploader for Codecov";
homepage = https://codecov.io/;
license = stdenv.lib.licenses.asl20;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not count on me to maintain this one. I'm not even sure what the package is supposed to be about.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Jul 1, 2017

Its fine adding such dependencies in the same PR as separate commits

Yes, I know but I created a separate PR because I finally failed making the tests run (see the other PR).
Since I spent much time making this package work (and since there is at least one other package in nixpkgs that disables the tests because a missing dependency on this one, cf. pkgs/development/tools/build-managers/conan/default.nix), I felt it could be useful to open this PR to share this work. However, I won't be able to maintain it, so feel free to close the PR if you don't think it is useful.

@FRidh FRidh merged commit 753aab1 into NixOS:master Jul 3, 2017
@Zimmi48 Zimmi48 deleted the add_codecov branch July 3, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants