-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.codecov: init at 2.0.9 #27018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this package because the tests for MarkdownSuperscripts (see #26985) depend on it.
Its fine adding such dependencies in the same PR as separate commits.
|
||
propagatedBuildInputs = [ requests coverage ]; | ||
|
||
patchPhase = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postPatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I'll change this.
meta = { | ||
description = "Python report uploader for Codecov"; | ||
homepage = https://codecov.io/; | ||
license = stdenv.lib.licenses.asl20; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not count on me to maintain this one. I'm not even sure what the package is supposed to be about.
Yes, I know but I created a separate PR because I finally failed making the tests run (see the other PR). |
Motivation for this change
I added this package because the tests for MarkdownSuperscripts (see #26985) depend on it.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)