Skip to content

cnijfilter: init at 2.80 #27031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2017
Merged

cnijfilter: init at 2.80 #27031

merged 1 commit into from
Jul 18, 2017
+156 −1

Conversation

jerith666
Copy link
Contributor

this driver reads libraries from lib/bjlib as well as lib/cups,
which is why the path in cupsd.nix is tweaked

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@jerith666, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @edolstra and @urkud to be potential reviewers.

@pSub pSub added the 8.has: package (new) This PR adds a new package label Jul 3, 2017
@bennofs
Copy link
Contributor

bennofs commented Jul 17, 2017

Thanks, this looks good!

this driver reads libraries from lib/bjlib as well as lib/cups, which is why the path in cupsd.nix is tweaked

But does the path in cupsd.nix actually influence where a driver can read libraries from? I would have assumed that it only influences $PATH, and libraries are handled by the rpath set at build time?

bennofs
bennofs suggested changes Jul 17, 2017
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -18255,6 +18255,8 @@ with pkgs;

cups-bjnp = callPackage ../misc/cups/drivers/cups-bjnp { };

cnijfilter = callPackage_i686 ../misc/cups/drivers/cnijfilter { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per your comment about versioning, we should probably call this cnijfilter_2_80 so it won't conflict with other versions of the driver.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, will do so and push a new version in the next couple of days.

@jerith666
Copy link
Contributor Author

What it reads from lib/bjlib are not .so files, but some kind of ancillary data files that (I guess) contain information about the printers it supports:

$ file /var/lib/cups/path/lib/bjlib/*
/var/lib/cups/path/lib/bjlib/cifip3500.conf:  ASCII text
/var/lib/cups/path/lib/bjlib/cifip4500.conf:  ASCII text
/var/lib/cups/path/lib/bjlib/cifmp140.conf:   ASCII text
/var/lib/cups/path/lib/bjlib/cifmp210.conf:   ASCII text
/var/lib/cups/path/lib/bjlib/cifmp520.conf:   ASCII text
/var/lib/cups/path/lib/bjlib/cifmp610.conf:   ASCII text
/var/lib/cups/path/lib/bjlib/cnb_3150.tbl:    TrueType font data
/var/lib/cups/path/lib/bjlib/cnb_3160.tbl:    TrueType font data
/var/lib/cups/path/lib/bjlib/cnb_3190.tbl:    TrueType font data
/var/lib/cups/path/lib/bjlib/cnb_3260.tbl:    TrueType font data
/var/lib/cups/path/lib/bjlib/cnb_3270.tbl:    TrueType font data
/var/lib/cups/path/lib/bjlib/cnb_3280.tbl:    TrueType font data
/var/lib/cups/path/lib/bjlib/cnbpname315.tbl: TrueType font data
/var/lib/cups/path/lib/bjlib/cnbpname316.tbl: TrueType font data
/var/lib/cups/path/lib/bjlib/cnbpname319.tbl: TrueType font data
/var/lib/cups/path/lib/bjlib/cnbpname326.tbl: TrueType font data
/var/lib/cups/path/lib/bjlib/cnbpname327.tbl: TrueType font data
/var/lib/cups/path/lib/bjlib/cnbpname328.tbl: TrueType font data

(I don't think those .tbl files are actually fonts, I think they're some kind of proprietary format.)

@jerith666
cnijfilter: init at 2.80
67d02cd 
this driver reads support files from lib/bjlib as well as lib/cups,
which is why the path in cupsd.nix is tweaked
@jerith666
Copy link
Contributor Author

@bennofs requested updates have been made in 67d02cd

@bennofs bennofs self-assigned this Jul 18, 2017
@bennofs bennofs merged commit 99fbd86 into NixOS:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennofs bennofs

Assignees

@bennofs bennofs

Labels
6.topic: printing 8.has: package (new) This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jerith666 @mention-bot @bennofs @pSub @FRidh