factorio: 0.15.16 -> 0.15.26 #27047
Merged
factorio: 0.15.16 -> 0.15.26 #27047
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elitak, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Baughn, @layus and @jbarthelmes to be potential reviewers. |
0xABAB
reviewed
Jul 2, 2017
| @@ -10,7 +10,7 @@ assert releaseType == "alpha" || releaseType == "headless" || releaseType == "de | |||
|
|
|||
| with stdenv.lib; | |||
| let | |||
| version = if releaseType != "demo" then "0.15.16" else "0.14.23"; | |||
| version = if releaseType != "demo" then "0.15.26" else "0.15.25"; | |||
There was a problem hiding this comment.
What's so special about this package that it requires the concept of a "demo"? Please add a comment in the source code, if this feature really needs to be there.
There was a problem hiding this comment.
probably the demo does not require a license.
There was a problem hiding this comment.
@Mic92 Thanks, I can confirm that now. Pretty cool game, judging by their media.
0xABAB
approved these changes
Jul 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Demo's been updated as well.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)