firefox wrapper: add libudev to libs #27053
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xABAB
reviewed
Jul 2, 2017
| @@ -48,7 +49,8 @@ let | |||
| ++ lib.optionals (cfg.enableQuakeLive or false) | |||
| (with xorg; [ stdenv.cc libX11 libXxf86dga libXxf86vm libXext libXt alsaLib zlib ]) | |||
| ++ lib.optional (enableAdobeFlash && (cfg.enableAdobeFlashDRM or false)) hal-flash | |||
| ++ lib.optional (config.pulseaudio or false) libpulseaudio; | |||
| ++ lib.optional (config.pulseaudio or false) libpulseaudio | |||
| ++ [ libudev ]; | |||
There was a problem hiding this comment.
Adding it to line 50 seems better.
Fixes NixOS#26913 (gamepad support).
lheckemann
force-pushed
the
firefox-gamepad
branch
from
997c35f to
b97747a
Compare
0xABAB
approved these changes
Jul 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #26913.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)